Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove wcag link and replace it with best practice in headings assessment guidance #2480

Merged
merged 2 commits into from
Apr 14, 2020
Merged

fix: remove wcag link and replace it with best practice in headings assessment guidance #2480

merged 2 commits into from
Apr 14, 2020

Conversation

Shobhit1
Copy link
Contributor

Description of changes

Remove the WCAG 1.3.1 link from headings guidance.

Pull request checklist

  • Addresses an existing issue: Guidance in Headings for top-level should be best practice  #2444
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

Screenshot

Screen Shot 2020-04-12 at 3 17 05 PM

@Shobhit1 Shobhit1 requested a review from a team as a code owner April 12, 2020 22:21
@msftclas
Copy link

msftclas commented Apr 13, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

waabid
waabid approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dbjorge dbjorge merged commit 10096c7 into microsoft:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waabid waabid waabid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shobhit1 @msftclas @waabid @dbjorge